Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/13399#discussion_r65308546 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -783,6 +783,16 @@ class DatasetSuite extends QueryTest with SharedSQLContext { ds.filter(_.b > 1).collect().toSeq } } + + test("transformed dataset correctly solve the attributes") { --- End diff -- Thanks a lot @cloud-fan for your review. I think the issue still exists, problem is that unit test actually doesn't reflect this issue, let me change the unit test. You could try the below to see the issue. ``` val dataset = Seq(1, 2, 3).toDS val mappedDataset = dataset.map(_ + 1) mappedDataset.as("t1").joinWith(mappedDataset.as("t2"), $"t1.value" === $"t2.value").show() ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org