Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1813#discussion_r15909585
  
    --- Diff: pom.xml ---
    @@ -249,6 +249,7 @@
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>
             <version>14.0.1</version>
    +        <scope>provided</scope>
    --- End diff --
    
    Also note that if you leave it as a compile-time dependency, and people are 
using Guava in their app, and not packaging Guava, *their app will fail to 
run*. Because the uber jar in the cluster won't have those classes.
    
    So saying "provided" here moves that particular error to the build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to