Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/13335#discussion_r65409815
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ContinuousQueryListenerBus.scala
---
@@ -69,14 +69,15 @@ class ContinuousQueryListenerBus(sparkListenerBus:
LiveListenerBus)
}
}
- /**
- * Wrapper for StreamingListenerEvent as SparkListenerEvent so that it
can be posted to Spark
- * listener bus.
- */
- private case class WrappedContinuousQueryListenerEvent(
- streamingListenerEvent: ContinuousQueryListener.Event) extends
SparkListenerEvent {
+}
- // Do not log streaming events in event log as history server does not
support these events.
- protected[spark] override def logEvent: Boolean = false
- }
+/**
+ * Wrapper for StreamingListenerEvent as SparkListenerEvent so that it can
be posted to Spark
+ * listener bus.
+ */
+case class WrappedContinuousQueryListenerEvent(
--- End diff --
I don't actually understand the structure of all the different even busses,
but why do we need a different event type? Why don't all the events just
extend `SparkListenerEvent`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
