Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13463#discussion_r65625548
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
---
@@ -490,6 +491,7 @@ class LocalityTestFileSystem extends RawLocalFileSystem
{
override def getFileBlockLocations(
file: FileStatus, start: Long, len: Long): Array[BlockLocation] = {
+ require(!file.isDirectory, "The file path can not be a directory.")
--- End diff --
This test suite already have test cases that create multiple partitions in
a table. and the code path in this PR is visited by these test cases. Adding
the require here will catch any case where a directory is passed to generate
block locations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
