Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13476#discussion_r65656447
  
    --- Diff: R/pkg/R/column.R ---
    @@ -151,6 +151,40 @@ setMethod("substr", signature(x = "Column"),
                 column(jc)
               })
     
    +#' startsWith
    +#'
    +#' Determines if entries of x start with string (entries of) prefix 
respectively,
    +#' where strings are recycled to common lengths.
    +#'
    +#' @rdname startsWith
    +#' @name startsWith
    +#' @family colum_func
    +#'
    +#' @param vector of character string whose “starts” are considered
    --- End diff --
    
    `@param` should be once per parameter. I think we should leave out `@param` 
on the next line since it is describing the same parameter.
    Also we should name the parameter first at the beginning of the text right 
after thr `@param` tag, see L146 for an example.
    Finally, add `@param` and description for `x`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to