Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13483#discussion_r65656657
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
@@ -224,6 +224,26 @@ class DatasetAggregatorSuite extends QueryTest with
SharedSQLContext {
checkAnswer(df.groupBy($"j").agg(RowAgg.toColumn), Row("a", 1) ::
Row("b", 5) :: Nil)
}
+ test("SPARK-15688: Remove redundant expressions from aggregate") {
+ val df = Seq(1 -> "a", 2 -> "b", 3 -> "b").toDF("col1", "col2")
--- End diff --
Could you use `WithSQLConf` here? This is to ensure this test case will not
be affected by the others or the future change in the default value of
`SQLConf.DATAFRAME_RETAIN_GROUP_COLUMNS.key`
Please also fix the related one in `DataFrameAggregateSuite` by adding
`WithSQLConf`:
https://github.com/apache/spark/blob/bb1362eb3b36b553dca246b95f59ba7fd8adcc8a/sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala#L210-L215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
