Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13061#discussion_r65748365
  
    --- Diff: core/src/main/scala/org/apache/spark/package.scala ---
    @@ -41,7 +41,53 @@ package org.apache
      * level interfaces. These are subject to changes or removal in minor 
releases.
      */
     
    +import java.util.Properties
    +
     package object spark {
    -  // For package docs only
    -  val SPARK_VERSION = "2.0.0-SNAPSHOT"
    +
    +  private object SparkBuildInfo {
    +    val resourceStream = Thread.currentThread().getContextClassLoader.
    --- End diff --
    
    Might also be a good idea to explicitly check that  `resourceStream` is not 
null (instead of throwing an NPE). Shouldn't ever happen, but well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to