Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13501#discussion_r65791157
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -338,12 +339,20 @@ case class WholeStageCodegenExec(child: SparkPlan)
extends UnaryExecNode with Co
new CodeAndComment(CodeFormatter.stripExtraNewLines(source),
ctx.getPlaceHolderToComments()))
logDebug(s"\n${CodeFormatter.format(cleanedSource)}")
- CodeGenerator.compile(cleanedSource)
(ctx, cleanedSource)
}
override def doExecute(): RDD[InternalRow] = {
val (ctx, cleanedSource) = doCodeGen()
+ // try to compile and fallback if it failed
+ try {
+ CodeGenerator.compile(cleanedSource)
+ } catch {
+ case e: Exception if !Utils.isTesting &&
sqlContext.conf.wholeStageFallback =>
+ // We should already saw the error message
+ logWarning(s"Temporary disable whole-stage codegen for this
plan:\n $treeString")
--- End diff --
"Whole-stage codegen disabled for this plan"
(remove temporary since it is already for only one plan)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
