Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13413#discussion_r65796528
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -88,14 +106,6 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
         checkKeywordsExist(sql("describe functioN abcadf"), "Function: abcadf 
not found.")
       }
     
    -  test("SPARK-14415: All functions should have own descriptions") {
    -    for (f <- spark.sessionState.functionRegistry.listFunction()) {
    -      if (!Seq("cube", "grouping", "grouping_id", "rollup", 
"window").contains(f)) {
    -        checkKeywordsNotExist(sql(s"describe function `$f`"), "N/A.")
    -      }
    -    }
    -  }
    -
    --- End diff --
    
    Why this test removed? We should check these functions have own description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to