Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13335#discussion_r65963035
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/ContinuousQueryListener.scala
---
@@ -70,26 +71,34 @@ abstract class ContinuousQueryListener {
object ContinuousQueryListener {
/**
- * Base type of [[ContinuousQueryListener]] events.
+ * Base type of [[ContinuousQueryListener]] events
* @since 2.0.0
*/
- trait Event
+ trait Event extends SparkListenerEvent
/**
- * Event representing the start of a query.
+ * Event representing the start of a query
* @since 2.0.0
*/
- class QueryStarted private[sql](val query: ContinuousQuery) extends Event
+ class QueryStarted private[sql](val queryInfo: ContinuousQueryInfo)
extends Event
/**
- * Event representing any progress updates in a query.
+ * Event representing any progress updates in a query
* @since 2.0.0
*/
- class QueryProgress private[sql](val query: ContinuousQuery) extends
Event
+ class QueryProgress private[sql](val queryInfo: ContinuousQueryInfo)
extends Event
/**
- * Event representing that termination of a query.
+ * Event representing that termination of a query
+ *
+ * @param queryInfo The query info.
+ * @param exception The exception message of the [[ContinuousQuery]] if
any. Otherwise, it
+ * will be `None`.
+ * @param stackTrace The stack trace of the exception if any.
* @since 2.0.0
*/
- class QueryTerminated private[sql](val query: ContinuousQuery) extends
Event
+ class QueryTerminated private[sql](
+ val queryInfo: ContinuousQueryInfo,
+ val exception: Option[String],
+ val stackTrace: Seq[StackTraceElement]) extends Event
--- End diff --
Isnt it more Java friendly to make this Array instead of Seq? It does not
need to be Seq.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
