Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13535#discussion_r65987602
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -190,6 +190,9 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ // Marks this as final, verboseString of Expression is NEVER called.
+ final override def verboseString: String = simpleString
+
--- End diff --
> Marks this as final, `Expression.verboseString` should never be called,
and thus shouldn't be overriden by concrete classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
