Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/13394#discussion_r66299402
--- Diff: R/pkg/R/mllib.R ---
@@ -197,11 +197,10 @@ print.summary.GeneralizedLinearRegressionModel <-
function(x, ...) {
invisible(x)
}
-#' Make predictions from a generalized linear model
-#'
#' Makes predictions from a generalized linear model produced by glm() or
spark.glm(),
#' similarly to R's predict().
#'
+#' @title predict
--- End diff --
I personally prefer using the first sentence as the convention to define
the title. One thing though is I'm not sure how the titles get collated when we
put multiple functions in the same doc page. @felixcheung do you know if using
`@title` would make it easier to have a canonical title in that case ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
