Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/13531#discussion_r66451629
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala
---
@@ -298,6 +309,28 @@ trait FileFormat {
}
/**
+ * The base class file format that is based on text file.
+ */
+abstract class TextBasedFileFormat extends FileFormat {
+ private var codecFactory: CompressionCodecFactory = null
+ override def isSplitable(
+ sparkSession: SparkSession,
+ options: Map[String, String],
+ path: Path): Boolean = {
+ if (codecFactory == null) {
+ synchronized {
+ if (codecFactory == null) {
+ codecFactory = new CompressionCodecFactory(
--- End diff --
sorry. It seems we can use `sparkSession.sessionState.newHadoopConf()`
instread of `sparkSession.sessionState.newHadoopConfWithOptions(options)` (I
checked the `FileSourceStrategySuite` test passed without passing `options` in
`CompressionCodecFactory`).
So, we need `options` in the arguments of `isSplitable`?
```
if (codecFactory == null) {
codecFactory = new
CompressionCodecFactory(sparkSession.sessionState.newHadoopConf())
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
