Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13549#discussion_r66491058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -43,6 +43,41 @@ object UnsupportedOperationChecker {
"Queries without streaming sources cannot be executed with
write.startStream()")(plan)
}
+ // Disallow multiple streaming aggregations
+ val aggregates = plan.collect { case a@Aggregate(_, _, _) if
a.isStreaming => a }
+
+ if (aggregates.size > 1) {
+ throwError(
+ "Multiple streaming aggregations are not supported with " +
+ "streaming DataFrames/Datasets")(plan)
+ }
+
+ // Disallow some output mode
+ outputMode match {
+ case InternalOutputModes.Append if aggregates.nonEmpty =>
+ throwError(
+ s"$outputMode output mode not supported when there are streaming
aggregations on " +
+ s"streaming DataFrames/DataSets")(plan)
+
+ case InternalOutputModes.Complete | InternalOutputModes.Update if
aggregates.isEmpty =>
+ throwError(
+ s"$outputMode output mode not supported when there are no
streaming aggregations on " +
+ s"streaming DataFrames/Datasets")(plan)
+
+ case _ =>
+ }
+
+ /**
+ * Whether the subplan will contain complete data or incremental data
in every incremental
+ * execution. Some operations may be allowed only when the child
logical plan gives complete
+ * data.
+ */
+ def containsCompleteData(subplan: LogicalPlan): Boolean = {
+ val aggs = plan.collect { case a@Aggregate(_, _, _) if a.isStreaming
=> a }
--- End diff --
I completely agree. This whole file needs to be restructured in future.
This is really a 2.0 interim fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
