Github user bomeng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13543#discussion_r66493098
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/master/MasterArguments.scala ---
    @@ -20,18 +20,24 @@ package org.apache.spark.deploy.master
     import scala.annotation.tailrec
     
     import org.apache.spark.SparkConf
    +import org.apache.spark.internal.Logging
     import org.apache.spark.util.{IntParam, Utils}
     
     /**
      * Command-line parser for the master.
      */
    -private[master] class MasterArguments(args: Array[String], conf: 
SparkConf) {
    +private[master] class MasterArguments(args: Array[String], conf: 
SparkConf) extends Logging {
       var host = Utils.localHostName()
       var port = 7077
       var webUiPort = 8080
       var propertiesFile: String = null
     
       // Check for settings in environment variables
    +  if (System.getenv("SPARK_MASTER_IP") != null) {
    +    logWarning("SPARK_MASTER_IP is deprecated, please use 
SPARK_MASTER_HOST")
    +    host = System.getenv("SPARK_MASTER_IP")
    +  }
    +
       if (System.getenv("SPARK_MASTER_HOST") != null) {
    --- End diff --
    
    MasterArguments.scala is used by Master.scala main() method, so there is a 
way to use `SPARK_MASTER_HOST


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to