Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13581#discussion_r66525010
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -434,24 +436,21 @@ abstract class UnixTime extends BinaryExpression with
ExpectsInputTypes {
left.dataType match {
case StringType if right.foldable =>
val sdf = classOf[SimpleDateFormat].getName
- val fString = if (constFormat == null) null else
constFormat.toString
- val formatter = ctx.freshName("formatter")
- if (fString == null) {
+ if (formatter == null) {
ev.copy(code = s"""
--- End diff --
this can be: `ev.copy(code = "", isNull = "false", value =
ctx.defaultValue(dataType))`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
