Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/13338#discussion_r66683769
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala ---
@@ -519,9 +519,9 @@ object YarnSparkHadoopUtil {
conf: SparkConf,
numExecutors: Int = DEFAULT_NUMBER_EXECUTORS): Int = {
if (Utils.isDynamicAllocationEnabled(conf)) {
- val minNumExecutors = conf.get(DYN_ALLOCATION_MIN_EXECUTORS)
- val initialNumExecutors = conf.get(DYN_ALLOCATION_INITIAL_EXECUTORS)
- val maxNumExecutors = conf.get(DYN_ALLOCATION_MAX_EXECUTORS)
+ val minNumExecutors = Utils.getDynamicAllocationMinExecutors(conf)
--- End diff --
`DYN_ALLOCATION_MIN_EXECUTORS` is a String property. Instead of relying on
the constants, this now standardizes on using functions in `Utils`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
