Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12836#discussion_r66691737
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -243,6 +243,55 @@ case class MapGroups(
outputObjAttr: Attribute,
child: LogicalPlan) extends UnaryNode with ObjectProducer
+/** Factory for constructing new `FlatMapGroupsInR` nodes. */
+object FlatMapGroupsInR {
+ def apply(
+ func: Array[Byte],
+ packageNames: Array[Byte],
+ broadcastVars: Array[Broadcast[Object]],
+ schema: StructType,
+ encoder: Expression,
+ keyEncoder: Expression,
+ rowEncoder: ExpressionEncoder[Row],
--- End diff --
Names of the above 3 parameters are quite confusing. The first two are
actually deserializer expressions rather than encoders, so I guess
`dataDeserializer` and `keyDeserializer` can be better names. The 3rd one is an
encoder, but seems that what we actually care about is only its schema.
Basically in most cases you can simply treat encoder as a pair of
serializer and deserializer expressions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
