Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/13447
  
    @yhuai You are right. This is not a good test case for verifying this. I 
will add a case like 
    ```scala
          sql(
            """
              |INSERT OVERWRITE TABLE table_with_partition
              |partition (p1='a',p2) IF NOT EXISTS
              |SELECT 'blarr3', 'newPartition'
            """.stripMargin)
    ```
    
    Actually, the above statement returns an empty result set, which is still a 
wrong answer.
    
    Regarding your follow-up question, I also realize this is another bug we 
should capture, as shown above: 
https://github.com/apache/spark/pull/13447#issuecomment-223409590. My original 
plan is to submit a PR for addressing that issue after 
https://github.com/apache/spark/pull/12313 is merged. If 
https://github.com/apache/spark/pull/12313 will not be merged in this release, 
I will do it now. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to