Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13524#discussion_r66834271
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -52,10 +52,10 @@ object TypeCoercion {
DecimalPrecision ::
BooleanEquality ::
StringToIntegralCasts ::
+ Division ::
--- End diff --
Just to be sure: are you moving the `Division` rule above the
`FunctionArgumentConversion` rule in order to pass correct double arguments to
functions? If so, could you add a test for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
