GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/13643

    [SPARK-15922][MLLIB] `toIndexedRowMatrix` should consider the case `cols < 
colsPerBlock`

    ## What changes were proposed in this pull request?
    
    SPARK-15922 reports the following scenario throwing an exception due to the 
mismatched vector sizes. This PR handles the exceptional case, `cols < 
colsPerBlock`.
    
    **Before**
    ```scala
    scala> import org.apache.spark.mllib.linalg.distributed._
    scala> import org.apache.spark.mllib.linalg._
    scala> val rows = IndexedRow(0L, new DenseVector(Array(1,2,3))) :: 
IndexedRow(1L, new DenseVector(Array(1,2,3))):: IndexedRow(2L, new 
DenseVector(Array(1,2,3))):: Nil
    scala> val rdd = sc.parallelize(rows)
    scala> val matrix = new IndexedRowMatrix(rdd, 3, 3)
    scala> val bmat = matrix.toBlockMatrix
    scala> val imat = bmat.toIndexedRowMatrix
    scala> imat.rows.collect
    ... throw exception
    ```
    
    **After**
    ```scala
    ...
    scala> imat.rows.collect
    res0: Array[org.apache.spark.mllib.linalg.distributed.IndexedRow] = 
Array(IndexedRow(0,[1.0,2.0,3.0]), IndexedRow(1,[1.0,2.0,3.0]), 
IndexedRow(2,[1.0,2.0,3.0]))
    ```
    
    ## How was this patch tested?
    
    Pass the Jenkins tests (including the above case)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-15922

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13643.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13643
    
----
commit 85054becae5eb0075620bd674d534ea27a9268b5
Author: Dongjoon Hyun <dongj...@apache.org>
Date:   2016-06-13T18:28:05Z

    [SPARK-15922][MLLIB] `toIndexedRowMatrix` should consider the case `cols < 
colsPerBlock`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to