Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13539
This PR seems kind of hacky to me. The optimization in
`GenerateUnsafeProject` which depends on the foldability of generated code is
also hacky. This is something our string based codegen framework doesn't
support essentially.
I think we should think about it more, and come up with a holistic
solution, i.e. find out all the patterns that represent a foldable value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
