Github user avati commented on a diff in the pull request:
https://github.com/apache/spark/pull/1704#discussion_r15980530
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -85,15 +85,28 @@ private[spark] object JettyUtils extends Logging {
path: String,
servletParams: ServletParams[T],
securityMgr: SecurityManager,
- basePath: String = ""): ServletContextHandler = {
+ basePath: String): ServletContextHandler = {
createServletHandler(path, createServlet(servletParams, securityMgr),
basePath)
}
+ def createServletHandler[T <% AnyRef](
+ path: String,
+ servletParams: ServletParams[T],
--- End diff --
I wanted to retain API (source) compatibility - to provide an API for
consumers who were depending on passing just path and servlet (I think there
was at least one such call)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
