Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13651#discussion_r66879738
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -2847,4 +2847,15 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
       test("SPARK-15887: hive-site.xml should be loaded") {
         assert(spark.sessionState.newHadoopConf().get("hive.in.test") == 
"true")
       }
    +
    +  test("SPARK-15776 Divide expression inside an Aggregation function 
should not " +
    --- End diff --
    
    I think we need some low level unit test instead of end-to-end test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to