Github user nblintao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13620#discussion_r66894846
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
    @@ -369,3 +361,246 @@ private[ui] class AllJobsPage(parent: JobsTab) 
extends WebUIPage("") {
         }
       }
     }
    +
    +private[ui] class JobTableRowData(
    +    val jobData: JobUIData,
    +    val lastStageName: String,
    +    val lastStageDescription: String,
    +    val duration: Long,
    +    val formattedDuration: String,
    +    val submissionTime: Long,
    +    val formattedSubmissionTime: String,
    +    val jobDescription: NodeSeq,
    +    val detailUrl: String)
    +
    +private[ui] class JobDataSource(
    +    jobs: Seq[JobUIData],
    +    stageIdToInfo: HashMap[Int, StageInfo],
    +    stageIdToData: HashMap[(Int, Int), StageUIData],
    +    basePath: String,
    +    currentTime: Long,
    +    pageSize: Int,
    +    sortColumn: String,
    +    desc: Boolean) extends PagedDataSource[JobTableRowData](pageSize) {
    +
    +  // Convert JobUIData to JobTableRowData which contains the final 
contents to show in the table
    +  // so that we can avoid creating duplicate contents during sorting the 
data
    +  private val data = jobs.map(jobRow).sorted(ordering(sortColumn, desc))
    +
    +  private var _slicedJobIds: Set[Int] = null
    +
    +  override def dataSize: Int = data.size
    +
    +  override def sliceData(from: Int, to: Int): Seq[JobTableRowData] = {
    +    val r = data.slice(from, to)
    +    _slicedJobIds = r.map(_.jobData.jobId).toSet
    +    r
    +  }
    +
    +  def slicedJobIds: Set[Int] = _slicedJobIds
    --- End diff --
    
    Sorry, it's deprecated. I will remove it. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to