Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13655#discussion_r66895475
  
    --- Diff: dev/sparktestsupport/modules.py ---
    @@ -337,6 +337,7 @@ def __hash__(self):
             "pyspark.sql.group",
             "pyspark.sql.functions",
             "pyspark.sql.readwriter",
    +        "pyspark.sql.streaming",
    --- End diff --
    
    this is pretty significant. I had no idea this file existed. I wonder if we 
could possibly add a check to the linter to catch new Python files appearing 
but not being added to this file? It's not a blocker message but an advisory 
one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to