Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13561#discussion_r66896852
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
---
@@ -225,7 +225,10 @@ private[hive] class SparkExecuteStatementOperation(
if (useIncrementalCollect) {
result.toLocalIterator.asScala
} else {
- result.collect().iterator
+
sqlContext.sessionState.executePlan(result.logicalPlan).executedPlan match {
+ case command: ExecutedCommandExec =>
command.executeCollectPublic().iterator
--- End diff --
Two things here:
1. I am pretty sure that not every `RunnableCommand` calls
`withNewExecutionId`. See `SetCommand` for instance. Maybe we should modify
`InsertIntoHadoopFsRelation` instead.
2. Technically a `Dataset.collect()` can return something else than a
`Row`, but I think this is OK since this is Thrift.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
