Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/13654#discussion_r67035475
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
---
@@ -53,6 +54,9 @@ private[ui] class ExecutorsPage(
// When GCTimePercent is edited change ToolTips.TASK_TIME to match
private val GCTimePercent = 0.1
+ // a safe String to Int for sorting ids (converts non-numeric Strings to
-1)
+ private def strToInt(str: String) : Int = Try(str.toInt).getOrElse(-1)
--- End diff --
That was my intention and why I chose to leave this function private in
ExecutorsPage rather than in a Utils file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
