GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/13672
[SPARK-15741][PYSPARK][ML] Pyspark cleanup of set default seed to None
## What changes were proposed in this pull request?
Several places set the seed Param default value to None which will
translate to a zero value on the Scala side. This is unnecessary because a
default fixed value already exists and if a test depends on a zero valued seed,
then it should explicitly set it to zero instead of relying on this
translation. These cases can be safely removed except for the ALS doc test,
which has been changed to set the seed value to zero.
## How was this patch tested?
Ran PySpark tests locally
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BryanCutler/spark
pyspark-cleanup-setDefault-seed-SPARK-15741
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13672.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13672
----
commit 0a04a797034e6208456569b88b8f9a31a16aae91
Author: Bryan Cutler <[email protected]>
Date: 2016-06-03T00:20:10Z
removed cases where setDefault seed=None
commit 8fa36ba59879e4b43dcbbe5672b3cb5d5775e503
Author: Bryan Cutler <[email protected]>
Date: 2016-06-14T15:37:01Z
explicitly set seed in ALS doc tests to match previous outputs
commit abe997da6c1ad00c1fd07df4f413e29eed2077f9
Author: Bryan Cutler <[email protected]>
Date: 2016-06-14T21:42:46Z
Merge remote-tracking branch 'upstream/master' into
pyspark-cleanup-setDefault-seed-SPARK-15741
Conflicts:
python/pyspark/ml/feature.py
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
