Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13631#discussion_r67091914
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -470,20 +470,16 @@ class Analyzer(
// Assume partition columns are correctly placed at the end
of the child's output
i.copy(table = EliminateSubqueryAliases(table))
} else {
- // Set up the table's partition scheme with all dynamic
partitions by moving partition
- // columns to the end of the column list, in partition order.
- val (inputPartCols, columns) = child.output.partition { attr
=>
- tablePartitionNames.contains(attr.name)
- }
// All partition columns are dynamic because this
InsertIntoTable had no partitioning
- val partColumns = tablePartitionNames.map { name =>
- inputPartCols.find(_.name == name).getOrElse(
- throw new AnalysisException(s"Cannot find partition
column $name"))
+ tablePartitionNames.filterNot { name =>
+ child.output.exists(_.name == name)
--- End diff --
hmm. indeed. As we use ordering not name, this check is not needed anymore.
I will remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
