Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13651#discussion_r67203936
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -128,12 +133,27 @@ class ArithmeticExpressionSuite extends SparkFunSuite
with ExpressionEvalHelper
checkEvaluation(Divide(left, Literal(convert(0))), null) // divide
by zero
}
- DataTypeTestUtils.numericTypeWithoutDecimal.foreach { tpe =>
+ Seq(DoubleType, DecimalType.SYSTEM_DEFAULT).foreach { tpe =>
checkConsistencyBetweenInterpretedAndCodegen(Divide, tpe, tpe)
}
}
- test("/ (Divide) for integral type") {
+ test("SPARK-15776: Divide report unresolved when children's data type is
" +
--- End diff --
This suite is to test the correctness, not resolution.
BTW, the resolution logic is defined by `ExpectedInputTypes`, I think we
don't need to test it again for divide.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
