Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9571#discussion_r67242040
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -395,7 +429,8 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
private def mergeApplicationListing(fileStatus: FileStatus): Unit = {
val newAttempts = try {
val bus = new ReplayListenerBus()
- val res = replay(fileStatus, bus)
+ val (res, count) = replay(fileStatus, bus)
+ metrics.eventReplayedCount.inc(count)
--- End diff --
You're using this metric in two different contexts: while creating the
listing, and while building the UI.
That means there's no good way to get a useful metric out of it, since you
don't know how many events correspond to each and you're measuring the times
for each separately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
