Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13730#discussion_r67481562
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -351,8 +354,10 @@ private[sql] object PartitioningUtils {
}
}
- if (partitionColumns.size == schema.fields.size) {
- throw new AnalysisException(s"Cannot use all columns for partition
columns")
+ if (schema.fields.isEmpty) {
--- End diff --
Thank you for review, @tdas.
Yes. Indeed. This is beyond of the scope of `PartitioningUtils`.
Actually, this logic is used 3 classes, `PreWriteCheck.`, `DataSource`,
`FileStreamSinkWriter`
I'll try to move this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
