Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13749#discussion_r67604063
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1317,4 +1317,28 @@ class DDLSuite extends QueryTest with
SharedSQLContext with BeforeAndAfterEach {
assertUnsupported("TRUNCATE TABLE my_tab PARTITION (age=10)")
}
+ test("SPARK-16034 Partition columns should match when appending to
existing data source tables") {
+ import testImplicits._
+ val df = Seq((1, 2, 3)).toDF("a", "b", "c")
+ withTable("partitionedTable") {
+ df.write.mode("overwrite").partitionBy("a",
"b").saveAsTable("partitionedTable")
+ // Misses some partition columns
+ intercept[AnalysisException] {
+
df.write.mode("append").partitionBy("a").saveAsTable("partitionedTable")
+ }
+ // Wrong order
+ intercept[AnalysisException] {
+ df.write.mode("append").partitionBy("b",
"a").saveAsTable("partitionedTable")
+ }
+ // Partition columns not specified
+ intercept[AnalysisException] {
+ df.write.mode("append").saveAsTable("partitionedTable")
+ }
+ assert(sql("select * from partitionedTable").collect().size == 1)
+ // Inserts new data successfully when partition columns are
correctly specified in
+ // partitionBy(...).
+ df.write.mode("append").partitionBy("a",
"b").saveAsTable("partitionedTable")
+ assert(sql("select * from partitionedTable").collect().size == 2)
--- End diff --
It's better to check the answer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
