Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13774#discussion_r67721810
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -911,6 +911,33 @@ setMethod("minute",
                 column(jc)
               })
     
    +#' monotonically_increasing_id
    +#'
    +#' Return a column that generates monotonically increasing 64-bit integers.
    +#'
    +#' The generated ID is guaranteed to be monotonically increasing and 
unique, but not consecutive.
    +#' The current implementation puts the partition ID in the upper 31 bits, 
and the record number
    +#' within each partition in the lower 33 bits. The assumption is that the 
data frame has
    --- End diff --
    
    Nice catch! We should use `SparkDataFrame` here for consistency.
    I'll fix this, too!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to