Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13763#discussion_r67725053
  
    --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
    @@ -1667,6 +1668,25 @@ test_that("mutate(), transform(), rename() and 
names()", {
       detach(airquality)
     })
     
    +test_that("read/write ORC files", {
    +  df <- read.df(jsonPath, "json")
    +
    +  # Test write.df and read.df
    +  write.df(df, orcPath, "orc", mode = "overwrite")
    +  df2 <- read.df(orcPath, "orc")
    +  expect_is(df2, "SparkDataFrame")
    +  expect_equal(count(df), count(df2))
    +
    +  # Test write.orc and read.orc
    +  orcPath2 <- tempfile(pattern = "orcPath2", fileext = ".orc")
    +  write.orc(df, orcPath2)
    +  orcDF <- read.orc(orcPath2)
    +  expect_is(orcDF, "SparkDataFrame")
    +  expect_equal(count(orcDF), count(df))
    +
    +  unlink(orcPath2)
    +})
    --- End diff --
    
    Oh, right. Thank you again.
    If possible, I want to keep them consistently with `Parquet` case.
    For `Orc` file, we can add more testcases in the future.
    I will add `unlink(orcPath1)` at the bottom of this R file, too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to