Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/13768#discussion_r67740472
--- Diff: R/pkg/R/functions.R ---
@@ -1179,6 +1179,27 @@ setMethod("soundex",
column(jc)
})
+#' spark_partition_id
--- End diff --
Minor nit: The convention we are using in SparkR is to have a descriptive
title for the function. So in this case it would be something like `Return the
partition ID as a column`. (There might be other places which need to fixed to
match this convention as well -- We discussed this in #13394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
