Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13738#discussion_r67876187
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 
---
    @@ -421,6 +421,13 @@ object SparkHadoopUtil {
     
       val SPARK_YARN_CREDS_COUNTER_DELIM = "-"
     
    +  // Just load HdfsConfiguration into the class loader to add
    +  // hdfs-site.xml as a default configuration file otherwise
    +  // some HDFS related configurations doesn't ship to Executors and
    +  // it can cause UnknownHostException when NameNode HA is enabled.
    +  // See SPARK-11227 for more details.
    +  Utils.classForName("org.apache.hadoop.hdfs.HdfsConfiguration")
    --- End diff --
    
    actually I'd prefer not to reference hdfs-site.xml directly.  
HdfsConfiguration should know what it needs to load.   For instance it also 
loads the defaults.  HdfsConfiguration is also marked as 
@InterfaceAudience.Private so ideally we shouldn't be using it directly.   
Based on my other comments I would like to understand better why this isn't 
loaded on driver already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to