GitHub user ahmed-mahran opened a pull request:

    https://github.com/apache/spark/pull/13825

    [SPARK-16120] [STREAMING] getCurrentLogFiles in ReceiverSuite WAL 
generating and cleaning case uses external variable instead of the passed 
parameter

    ## What changes were proposed in this pull request?
    
    In `ReceiverSuite.scala`, in the test case "write ahead log - generating 
and cleaning", the inner method `getCurrentLogFiles` uses external variable 
`logDirectory1` instead of the passed parameter `logDirectory`. This PR fixes 
this by using the passed method argument instead of variable from the outer 
scope.
    
    
    ## How was this patch tested?
    
    The unit test was re-run and the output logs were checked for the correct 
paths used.
    
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahmed-mahran/spark 
b-receiver-suite-wal-gen-cln

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13825.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13825
    
----
commit f689cce93ba21fd25341c5c142747ba0821f0572
Author: Ahmed Mahran <ahmed.mah...@mashin.io>
Date:   2016-06-21T21:39:51Z

    Use passed method argument instead of variable from outer scope

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to