Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/13818#discussion_r68064203
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/parquetSuites.scala ---
@@ -425,6 +425,28 @@ class ParquetMetastoreSuite extends
ParquetPartitioningTest {
}
}
+ test("SPARK-15968: nonempty partitioned metastore Parquet table lookup
should use cached " +
--- End diff --
I looked in `CachedTableSuite`. I'm not sure that's a good place for this
kind of test. That test suite seems focused on testing tables cached by the
[CacheManager](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala).
This patch is focused on table caching in
[HiveMetastoreCatalog](https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala).
It's difficult to find the best place for these kinds of caching tests. I
chose this file because it already had some of these tests. Perhaps
[HiveMetastoreCatalogSuite](https://github.com/apache/spark/blob/master/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala)
would be a good candidate for an alternative?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
