Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13829#discussion_r68131571
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +60,11 @@ public BufferHolder(UnsafeRow row, int initialSize) {
* Grows the buffer by at least neededSize and points the row to the
buffer.
*/
public void grow(int neededSize) {
+ if (neededSize > Integer.MAX_VALUE / 2 - totalSize()) {
--- End diff --
`final int length = totalSize() + neededSize;`, this can cause integer
overflow, as well as `length * 2`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
