Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1880#discussion_r16036262
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/columnar/InMemoryColumnarTableScan.scala
 ---
    @@ -90,22 +101,31 @@ private[sql] case class InMemoryColumnarTableScan(
     
       override def execute() = {
         relation.cachedColumnBuffers.mapPartitions { iterator =>
    -      val columnBuffers = iterator.next()
    -      assert(!iterator.hasNext)
    +      // Find the ordinals of the requested columns.  If none are 
requested, use the first.
    +      val requestedColumns =
    +        if (attributes.isEmpty) {
    +          Seq(0)
    --- End diff --
    
    Yeah, that would be better.  Really though I think we should use statistics 
from #1883 to skip decoding entirely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to