GitHub user ueshin opened a pull request:

    https://github.com/apache/spark/pull/13873

    [SPARK-16167][SQL] RowEncoder should preserve array/map type nullability.

    ## What changes were proposed in this pull request?
    
    Currently `RowEncoder` doesn't preserve nullability of `ArrayType` or 
`MapType`.
    It returns always `containsNull = true` for `ArrayType`, `valueContainsNull 
= true` for `MapType` and also the nullability of itself is always `true`.
    
    This pr fixes the nullability of them.
    
    ## How was this patch tested?
    
    Add tests to check if `RowEncoder` preserves array/map nullability.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ueshin/apache-spark issues/SPARK-16167

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13873.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13873
    
----
commit f64f570430648983fd8a3664c526d96de710ea64
Author: Takuya UESHIN <ues...@happy-camper.st>
Date:   2016-06-23T06:33:04Z

    Add tests to check if RowEncoder preserves array/map nullability.

commit 093a9fa9039e1403e5f9ec9e0ab5f422f97f0fc4
Author: Takuya UESHIN <ues...@happy-camper.st>
Date:   2016-06-23T06:44:39Z

    Modify RowEncoder and MapObjects to preserve array/map nullability.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to