Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/13852#discussion_r68474108 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala --- @@ -174,8 +174,8 @@ sealed abstract class AggregateFunction extends Expression with ImplicitCastInpu def inputAggBufferAttributes: Seq[AttributeReference] /** - * Indicates if this function supports partial aggregation. - * Currently Hive UDAF is the only one that doesn't support partial aggregation. + * Indicates if this function needs to aggregate values group-by-group in a single step. + * If false, we must always use a `SortAggregateExec` operator without partial aggregates. */ def supportsPartial: Boolean = true --- End diff -- okay. Since the suggested fix changes the code, I'll create a new jira ticket and attach this pr with it.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org