Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1893#discussion_r16066884
  
    --- Diff: examples/pom.xml ---
    @@ -110,36 +143,52 @@
           <version>${project.version}</version>
         </dependency>
         <dependency>
    -      <groupId>org.apache.hbase</groupId>
    -      <artifactId>hbase</artifactId>
    -      <version>${hbase.version}</version>
    -      <exclusions>
    -        <exclusion>
    -          <groupId>asm</groupId>
    -          <artifactId>asm</artifactId>
    -        </exclusion>
    -        <exclusion>
    -          <groupId>org.jboss.netty</groupId>
    -          <artifactId>netty</artifactId>
    -        </exclusion>
    -        <exclusion>
    -          <groupId>io.netty</groupId>
    -          <artifactId>netty</artifactId>
    -        </exclusion>
    -        <exclusion>
    -          <groupId>commons-logging</groupId>
    -          <artifactId>commons-logging</artifactId>
    -        </exclusion>
    -        <exclusion>
    -          <groupId>org.jruby</groupId>
    -          <artifactId>jruby-complete</artifactId>
    -        </exclusion>
    -      </exclusions>
    -    </dependency>
    -    <dependency>
           <groupId>org.eclipse.jetty</groupId>
           <artifactId>jetty-server</artifactId>
         </dependency>
    +      <dependency>
    +        <groupId>org.apache.hbase</groupId>
    +        <artifactId>hbase-testing-util</artifactId>
    +        <version>${hbase.version}</version>
    +        <exclusions>
    +          <exclusion>
    +            <groupId>org.jruby</groupId>
    +            <artifactId>jruby-complete</artifactId>
    +          </exclusion>
    +        </exclusions>
    +      </dependency>
    +      <dependency>
    +        <groupId>org.apache.hbase</groupId>
    +        <artifactId>hbase-protocol</artifactId>
    +        <version>${hbase.version}</version>
    +      </dependency>
    +      <dependency>
    +        <groupId>org.apache.hbase</groupId>
    +        <artifactId>hbase-common</artifactId>
    +        <version>${hbase.version}</version>
    +      </dependency>
    +      <dependency>
    +        <groupId>org.apache.hbase</groupId>
    --- End diff --
    
    Have you checked that none of the deps that were excluded before need to be 
excluded again? for example we don't want Commons Logging or any Netty coming 
in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to