Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13915#discussion_r68534330
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/IsotonicRegressionExample.scala
---
@@ -55,7 +55,7 @@ object IsotonicRegressionExample {
}
// Calculate mean squared error between predicted and real labels.
- val meanSquaredError = predictionAndLabel.map { case (p, l) =>
math.pow((p - l), 2) }.mean()
+ val meanSquaredError = predictionAndLabel.map { case (p, la) =>
math.pow((p - la), 2) }.mean()
--- End diff --
You could write out a little more, like pred and label, in cases like this.
If we're going to expand them might as well do more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
