Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/13758
  
    If we do need ```Object[]```,  specialized ```GenericArrayData``` would not 
help us due to three reason.
    
    1. To pass ```Object[]``` cannot exploit specialized ```GenericArrayData``` 
since signature of generalized as ```Object[]```. Each element could have a 
value with different classes. 
    2. To pass ```Object[]``` causes boxing at an assignment in the generated 
code (e.g. Line 064 of "Generated code before applying this PR" in 
https://github.com/apache/spark/pull/13704)
    3. To keep ```Object[]``` causes unboxing at 
```GenericArrayData.get<PrimitiveType>()``` or 
```GenericArrayData.to<PrimitiveType>Array()``` in the generated code (e.g. 
Line 064 of "Generated code before applying this PR" in 
https://github.com/apache/spark/pull/13704).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to