Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13846#discussion_r68751774
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -167,6 +169,43 @@ case class MapElements(
outputObjAttr: Attribute,
child: LogicalPlan) extends ObjectConsumer with ObjectProducer
+object TypedFilter {
+ def apply[T : Encoder](func: AnyRef, child: LogicalPlan): TypedFilter = {
+ TypedFilter(func, UnresolvedDeserializer(encoderFor[T].deserializer),
child)
+ }
+}
+
+/**
+ * A relation produced by applying `func` to each element of the `child`
and filter them by the
+ * resulting boolean value.
+ *
+ * This is logically equal to a normal [[Filter]] operator whose condition
expression is decoding
+ * the input row to object and apply the given function with decoded
object. However we need the
+ * encapsulation of [[TypedFilter]] to make the concept more clear and
make it easier to write
+ * optimizer rules.
+ */
+case class TypedFilter(
+ func: AnyRef,
+ deserializer: Expression,
+ child: LogicalPlan) extends UnaryNode {
+
+ override def output: Seq[Attribute] = child.output
+
+ def withObject(obj: LogicalPlan): Filter = {
--- End diff --
How about renaming this method to `withObjectProducerChild`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
