Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13964#discussion_r68884143
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala
---
@@ -26,7 +26,7 @@ import org.apache.spark.sql.types._
* A literal value that is not foldable. Used in expression codegen
testing to test code path
* that behave differently based on foldable values.
*/
-case class NonFoldableLiteral(value: Any, dataType: DataType) extends
LeafExpression {
+case class NonFoldableLiteral(var value: Any, dataType: DataType) extends
LeafExpression {
--- End diff --
It's ok if we do save a lot of effort because of it, but seems we don't?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
