Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13941#discussion_r68916835
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -881,10 +881,11 @@ class LDA @Since("1.6.0") (
}
-private[clustering] object LDA extends DefaultParamsReadable[LDA] {
+object LDA extends DefaultParamsReadable[LDA] {
/** Get dataset for spark.mllib LDA */
- def getOldDataset(dataset: Dataset[_], featuresCol: String): RDD[(Long,
OldVector)] = {
+ private[clustering] def getOldDataset(dataset: Dataset[_], featuresCol:
String):
+ RDD[(Long, OldVector)] = {
--- End diff --
Usually we use indent like this:
```
private[clustering] def getOldDataset(
dataset: Dataset[_],
featuresCol: String): RDD[(Long, OldVector)] = {
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
